Skip to content

Record missing ti_failure metrics for tasks in Airflow 3 #59731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 2 commits into from
Dec 31, 2025
Merged

Record missing ti_failure metrics for tasks in Airflow 3 #59731

potiuk merged 2 commits into from
Dec 31, 2025

Conversation

@seanmuth
Copy link
Contributor

@seanmuth seanmuth commented Dec 22, 2025

Fix missing ti_failure metrics in Airflow3 Task SDK

Related PR: #55322

Adds ti_failure stats to task SDK's _handle_current_task_failed() method, in the same way ti_successes were added to _handle_current_task_success()

@amoghrajesh amoghrajesh changed the title emit ti failures stats Record missing ti_failure metrics for tasks in Airflow 3 Dec 23, 2025
@potiuk
Copy link
Member

potiuk commented Dec 23, 2025

One space misaligned :( . prek to the rescue

@seanmuth
Copy link
Contributor Author

seanmuth commented Dec 30, 2025

Whoops @potiuk ! Totally forgot I nuked my local dev env at some point during the year and forgot to setup prek again, I knew something was missing on my end. Fixed, should be good now.

@potiuk potiuk force-pushed the add-ti-failures-task-sdk branch from 55b738c to 34c8e26 Compare December 31, 2025 00:28
@amoghrajesh
Copy link
Contributor

amoghrajesh commented Dec 31, 2025

Can we target this for 3.1.6?

@potiuk potiuk added this to the Airflow 3.1.6 milestone Dec 31, 2025
@potiuk potiuk added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Dec 31, 2025
@potiuk potiuk merged commit 98d5976 into apache:main Dec 31, 2025
99 checks passed
@potiuk
Copy link
Member

potiuk commented Dec 31, 2025

Can we target this for 3.1.6?

Let's see :)

github-actions bot pushed a commit that referenced this pull request Dec 31, 2025
@seanmuth
[v3-1-test] Record missing ti_failure metrics for tasks in Airflow 3 (
cdc9511 
#59731)

* emit ti failures stats

* fix whitespace, comment
(cherry picked from commit 98d5976)

Co-authored-by: Sean Muth <seanmuth@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Dec 31, 2025

Backport successfully created: v3-1-test

Status Branch Result
✅ v3-1-test PR Link

potiuk pushed a commit that referenced this pull request Dec 31, 2025
@github-actions @seanmuth
[v3-1-test] Record missing ti_failure metrics for tasks in Airflow 3 (
d3149fa 
#59731) (#59964)

* emit ti failures stats

* fix whitespace, comment
(cherry picked from commit 98d5976)

Co-authored-by: Sean Muth <seanmuth@users.noreply.github.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Jan 2, 2026
@seanmuth @Subham-KRLX
Record missing ti_failure metrics for tasks in Airflow 3 (apache#59731
dc48170 
)

* emit ti failures stats

* fix whitespace, comment
ephraimbuddy pushed a commit that referenced this pull request Jan 6, 2026
@github-actions @seanmuth @ephraimbuddy
[v3-1-test] Record missing ti_failure metrics for tasks in Airflow 3 (
0c3b8e1 
#59731) (#59964)

* emit ti failures stats

* fix whitespace, comment
(cherry picked from commit 98d5976)

Co-authored-by: Sean Muth <seanmuth@users.noreply.github.com>
stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
@seanmuth @stegololz
Record missing ti_failure metrics for tasks in Airflow 3 (apache#59731
06a63ae 
)

* emit ti failures stats

* fix whitespace, comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@amoghrajesh amoghrajesh amoghrajesh approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

Assignees

No one assigned

Labels

area:task-sdk backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

Airflow 3.1.6

Development

Successfully merging this pull request may close these issues.

3 participants

@seanmuth @potiuk @amoghrajesh